Hacker News .hnnew | past | comments | ask | show | jobs | submitlogin

I don't know, I wouldn't judge a decompiled code.

Can you give a few examples why is it so bad?



Keep in mind this is decompiled from IL, so the class/method/object mapping and naming remains from the original binary.

Here are a few, in my opinion, ugly examples:

https://github.com/wybory2014/Kalkulator1/blob/master/Kalkul... and https://github.com/wybory2014/Kalkulator1/blob/master/Kalkul... and a few more instances of basically the same logic, copy-pasted (correct me if this might have been optimized from source code, as I'm a reverse engineer and not a C# programmer - but I'm pretty sure it's not)

https://github.com/wybory2014/Kalkulator1/blob/master/Kalkul...

https://github.com/wybory2014/Kalkulator1/blob/master/Kalkul...

https://github.com/wybory2014/Kalkulator1/blob/master/Kalkul...

https://github.com/wybory2014/Kalkulator1/blob/master/Kalkul... and string-based HTML generation in general. Oh, and this method in general. It doesn't even fit on my screen without scrolling to the right.

I'm not saying it's a goldmine of DailyWTF-worth content - but it's still pretty bad. In general, it doesn't really follow any MVC-separation, the naming is arbitraty at best (and dictated by the IDE at worst - Kalkulator1, anyone?), and DRY principles are vastly ignored.





Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: