I do this a lot on PRs, especially for small fixes. I’ll make sure to put a comment explaining my changes and link to the relevant doc about why the change was made.
It doesn’t make sense to ask contributors (especially new ones) to spend time going back and forth on such small changes. It’s better use of both our times if I take a few minutes to make the small changes and merge in.
For more complex PRs, my guiding principle is:
- Make those changes that might require a lot of back and forth and harder to explain or might be subjective.
It doesn’t make sense to ask contributors (especially new ones) to spend time going back and forth on such small changes. It’s better use of both our times if I take a few minutes to make the small changes and merge in.
For more complex PRs, my guiding principle is:
- Make those changes that might require a lot of back and forth and harder to explain or might be subjective.
- Request changes that are objective.