> So if an offender turns off iCloud then this move will absolutely be useless??

No on-device photo scanning unless iCloud Photos is enabled. Isn't funny when you get the most important aspect wrong?

> How would that help catch them if they can simply flip the switch?

They never claimed that this would help "catch them" if they are not using iCloud Photos.